chore(avatar): convert examples to typescript #6228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
PF4 preview: https://patternfly-react-pr-6228.surge.sh |
redallen
force-pushed
the
ts/avatar-examples
branch
from
910dfbd to
247ff9d
Compare
nicolethoen
approved these changes
Aug 30, 2021
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
Do you need to do anything extra so the cypress tests use these examples after removing the demos from the demo-app?
Contributor
Author
|
@nicolethoen I talked to @tlabaj and we agreed we can remove integration tests that only test class names as long as we continue to test our breakpoint utility. But yes, I'll have to do something extra for CI to use our doc build instead of demo app. |
tlabaj
approved these changes
Aug 31, 2021
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #6118
Additional issues: