Skip to content

Conversation

@nicolethoen
Copy link
Contributor

What: Closes #6633

@nicolethoen nicolethoen force-pushed the alerts_functional_ts_examples branch from 94448fa to c2add3d Compare November 19, 2021 20:46
@patternfly-build
Copy link
Collaborator

patternfly-build commented Nov 19, 2021

@nicolethoen nicolethoen force-pushed the alerts_functional_ts_examples branch from 5515152 to e9bd8d7 Compare December 2, 2021 16:56
@gabipodolnikova
Copy link
Contributor

Just one small thing: I see the Async live region alert example with a differently styled buttons than in the other examples. Do you also see it?

@nicolethoen
Copy link
Contributor Author

@gabipodolnikova yes! That's because it's using a toggleGroup instead of buttons. it is sort of an on/off switch, when the others are buttons... is it distracting? I did update it to use the toggleGroup - I figured it was a good use case but it is unnecessary.

@gabipodolnikova
Copy link
Contributor

@gabipodolnikova yes! That's because it's using a toggleGroup instead of buttons. it is sort of an on/off switch, when the others are buttons... is it distracting? I did update it to use the toggleGroup - I figured it was a good use case but it is unnecessary.

Ah okay, it just surprised me, that it looks different than the others. it is a little bit distracting for me, but maybe get another opinion. Otherwise I am approving this :)

@nicolethoen nicolethoen merged commit 37b9397 into patternfly:main Dec 6, 2021
@nicolethoen nicolethoen deleted the alerts_functional_ts_examples branch February 8, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alert: Convert examples to typescript

4 participants