chore: Add Testing Library packages, update simple enzyme tests #6921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-6921.surge.sh A11y report: https://patternfly-react-pr-6921-a11y.surge.sh |
Contributor
|
@jeffpuzzo could you rebase? |
jpuzz0
force-pushed
the
chore/add-react-testing-library
branch
from
247663a to
ce3214e
Compare
nicolethoen
approved these changes
Mar 2, 2022
tlabaj
approved these changes
Mar 2, 2022
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #6920
Actions taken
shallowormount(from enzyme) withrender(from @testing-library/react). Avoided any tests that involved implementation details, which require more thought specific to each component.Outstanding test suites using Enzyme
Before this change: 443
After this change: 104 (Most of these have React Testing Library mixed in with them)