chore: Migrate tests to RTL (1) #7020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-7020.surge.sh A11y report: https://patternfly-react-pr-7020-a11y.surge.sh |
jpuzz0
force-pushed
the
chore/rtl-migrate-bundle-1
branch
from
325b3cf to
eab470f
Compare
Collaborator
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
For the goal of getting us off Enzyme and on RTL this looks good to me.
Does look like some merge conflicts need to be fixed though, once those are done I'm ready to approve.
tlabaj
approved these changes
Mar 17, 2022
Contributor
tlabaj
left a comment
tlabaj
left a comment
There was a problem hiding this comment.
LGTM! We can merge once conflicts are resolved.
jpuzz0
force-pushed
the
chore/rtl-migrate-bundle-1
branch
from
eab470f to
7fca893
Compare
wise-king-sullyman
approved these changes
Mar 17, 2022
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
wise-king-sullyman
pushed a commit
to wise-king-sullyman/patternfly-react
that referenced
this pull request
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #7019