Skip to content

Conversation

@thatblindgeye
Copy link
Contributor

What: Closes #7024

Additional issues:

@patternfly-build
Copy link
Collaborator

patternfly-build commented Mar 9, 2022

Copy link
Contributor

@gitdallas gitdallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure the "SingleChip" name makes sense anymore considering there are several chips in the example and it isn't being bundled with the chipGroup anymore for contrast, but it's just a name

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tlabaj tlabaj merged commit d915b21 into patternfly:main Mar 17, 2022
@thatblindgeye thatblindgeye deleted the chip_conversion branch March 21, 2022 12:36
wise-king-sullyman pushed a commit to wise-king-sullyman/patternfly-react that referenced this pull request Mar 23, 2022
…tternfly#7038)

* chore(Chip): convert examples to TypeScript/functional components

* Rename example file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chip: convert examples to TypeScript

4 participants