chore(DatePicker): convert examples to TS #7160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-7160.surge.sh A11y report: https://patternfly-react-pr-7160-a11y.surge.sh |
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Looks good! Possibly a nitpick as I can't recall if it's mentioned anywhere, but usually I believe the export names have been the same as the file names (so instead of export const AmericanFormat... it'd be export const DatePickerAmerican... and so on). Do you have any opinion either way on that?
Contributor
Author
|
Thank you @thatblindgeye ! Yes, that's a great convention to follow - I've updated all these export names in my open PRs to now match their corresponding file names. |
thatblindgeye
approved these changes
Apr 4, 2022
nicolethoen
approved these changes
Apr 11, 2022
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #7140