Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions packages/react-core/src/helpers/Popper/Popper.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -149,13 +149,11 @@ export const Popper: React.FunctionComponent<PopperProps> = ({
const [popperElement, setPopperElement] = React.useState(null);
const [ready, setReady] = React.useState(false);
const refOrTrigger = refElement || triggerElement;
const onDocumentClickCallback = React.useCallback(event => onDocumentClick(event, refOrTrigger, popperElement), [
isVisible,
triggerElement,
refElement,
popperElement,
onDocumentClick
]);
const onDocumentClickCallback = React.useCallback(
(event: MouseEvent) => onDocumentClick(event, refOrTrigger, popperElement),
[isVisible, triggerElement, refElement, popperElement, onDocumentClick]
);

React.useEffect(() => {
setReady(true);
}, []);
Expand Down
2 changes: 1 addition & 1 deletion packages/react-topology/src/behavior/useBendpoint.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export const useBendpoint = <DropResult, CollectedProps, Props = {}>(
);

// argh react events don't play nice with d3 pan zoom double click event
const ref = React.useCallback(
const ref = React.useCallback<ConnectDragSource>(
node => {
d3.select(node).on(
'click',
Expand Down
2 changes: 1 addition & 1 deletion packages/react-topology/src/components/popper/Popper.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ const Popper: React.FunctionComponent<PopperProps> = ({
onClickOutside
]);

const nodeRefCallback = React.useCallback(
const nodeRefCallback = React.useCallback<React.RefCallback<HTMLDivElement>>(
node => {
nodeRef.current = node;
initialize();
Expand Down