Skip to content

chore(Page): update centered example to match Core #7269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 1 commit into from
May 2, 2022
Merged

chore(Page): update centered example to match Core #7269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions packages/react-core/src/components/Page/examples/Page.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,11 +264,10 @@ class FillPage extends React.Component {
return (
<Page header={Header} sidebar={Sidebar}>
<PageSection>A default page section</PageSection>
<PageSection isFilled={true}>
This section fills the available space.
</PageSection>
<PageSection isFilled={true}>This section fills the available space.</PageSection>
<PageSection isFilled={false}>
This section is set to not fill the available space, since the last page section is set to fill the available space by default.
This section is set to not fill the available space, since the last page section is set to fill the available
space by default.
</PageSection>
</Page>
);
Expand Down Expand Up @@ -590,7 +589,7 @@ class VerticalPage extends React.Component {
}
```

### Centered content
### Centered section

```js
import React from 'react';
Expand All @@ -607,7 +606,9 @@ import {
PageToggleButton,
Toolbar,
ToolbarContent,
ToolbarItem
ToolbarItem,
Card,
CardBody
} from '@patternfly/react-core';
import BarsIcon from '@patternfly/react-icons/dist/esm/icons/bars-icon';

Expand Down Expand Up @@ -639,7 +640,16 @@ CenterAlignedPageSection = () => {
return (
<Page header={Header}>
<PageSection isWidthLimited isCenterAligned>
Page section width limited, centered.
<Card>
<CardBody>
When a width limited page section is wider than the value of
<code>--pf-c-page--section--m-limit-width--MaxWidth</code>, the section will be centered in the main section.
<br />
<br />
The content in this example is placed in a card to better illustrate how the section behaves when it is
centered. A card is not required to center a page section.
</CardBody>
</Card>
</PageSection>
</Page>
);
Expand Down