feat(table): add fullscreen loading state demo #7370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-7370.surge.sh A11y report: https://patternfly-react-pr-7370-a11y.surge.sh |
jenny-s51
changed the title
mcarrano
approved these changes
May 6, 2022
Member
mcarrano
left a comment
mcarrano
left a comment
There was a problem hiding this comment.
This looks great @jenny-s51 . Please disregard my comment on your other PR then as I didn't realize you were making these demo changes separately.
mmenestr
approved these changes
May 6, 2022
tlabaj
approved these changes
May 6, 2022
mcoker
requested changes
May 24, 2022
Contributor
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
LGTM! Just a couple of small nits.
Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #7342
Convenience link to demo: https://patternfly-react-pr-7370.surge.sh/components/table/react-demos/loading/