Skip to content

feat(table): convert column mgmt demos to fullscreen #7446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jenny-s51 wants to merge 1 commit into from
Closed

feat(table): convert column mgmt demos to fullscreen #7446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 56 additions & 38 deletions packages/react-table/src/demos/Table.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,10 +293,11 @@ class BulkSelectTableDemo extends React.Component {

### Column management

```js
```js isFullscreen
import React from 'react';
import {
Button,
Card,
DataList,
DataListCheck,
DataListItem,
Expand All @@ -312,6 +313,7 @@ import {
OverflowMenuItem,
OptionsMenu,
OptionsMenuToggle,
PageSection,
Pagination,
PaginationVariant,
Text,
Expand All @@ -325,6 +327,7 @@ import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-i
import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';
import FilterIcon from '@patternfly/react-icons/dist/esm/icons/filter-icon';
import SortAmountDownIcon from '@patternfly/react-icons/dist/esm/icons/sort-amount-down-icon';
import DashboardWrapper from '@patternfly/react-core/src/demos/examples/DashboardWrapper';

class ColumnManagementAction extends React.Component {
constructor(props) {
Expand Down Expand Up @@ -898,24 +901,30 @@ class ColumnManagementAction extends React.Component {

return (
<React.Fragment>
<Table
gridBreakPoint="grid-xl"
header={
<React.Fragment>
<Toolbar id="page-layout-table-column-management-action-toolbar-top">{toolbarItems}</Toolbar>
</React.Fragment>
}
aria-label="This is a table with checkboxes"
id="page-layout-table-column-management-action-table"
onSelect={this.onSelect}
cells={columns}
rows={rows}
actions={this.actions}
canSelectAll={canSelectAll}
>
<TableHeader />
<TableBody />
</Table>
<DashboardWrapper hasPageTemplateTitle>
<PageSection padding={{ default: 'noPadding', xl: 'padding' }}>
<Card component="div">
<Table
gridBreakPoint="grid-xl"
header={
<React.Fragment>
<Toolbar id="page-layout-table-column-management-action-toolbar-top">{toolbarItems}</Toolbar>
</React.Fragment>
}
aria-label="This is a table with checkboxes"
Copy link
Contributor

@thatblindgeye thatblindgeye Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
aria-label="This is a table with checkboxes"
aria-label="This is a table with column management"

id="page-layout-table-column-management-action-table"
onSelect={this.onSelect}
cells={columns}
rows={rows}
actions={this.actions}
canSelectAll={canSelectAll}
>
<TableHeader />
<TableBody />
</Table>
</Card>
</PageSection>
</DashboardWrapper>
<Pagination
isCompact
id="page-layout-table-column-management-action-toolbar-bottom"
Expand All @@ -933,10 +942,11 @@ class ColumnManagementAction extends React.Component {

### Column management with draggable

```js
```js isFullscreen
import React from 'react';
import {
Button,
Card,
DataList,
DataListCheck,
DataListControl,
Expand All @@ -954,6 +964,7 @@ import {
OverflowMenuItem,
OptionsMenu,
OptionsMenuToggle,
PageSection,
Pagination,
PaginationVariant,
Text,
Expand All @@ -967,6 +978,7 @@ import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-i
import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';
import FilterIcon from '@patternfly/react-icons/dist/esm/icons/filter-icon';
import SortAmountDownIcon from '@patternfly/react-icons/dist/esm/icons/sort-amount-down-icon';
import DashboardWrapper from '@patternfly/react-core/src/demos/examples/DashboardWrapper';

class ColumnManagementAction extends React.Component {
constructor(props) {
Expand Down Expand Up @@ -1661,24 +1673,30 @@ class ColumnManagementAction extends React.Component {

return (
<React.Fragment>
<Table
gridBreakPoint="grid-xl"
header={
<React.Fragment>
<Toolbar id="page-layout-table-column-management-action-toolbar-top">{toolbarItems}</Toolbar>
</React.Fragment>
}
aria-label="This is a table with checkboxes"
id="page-layout-table-column-management-action-table"
onSelect={this.onSelect}
cells={columns}
rows={rows}
actions={this.actions}
canSelectAll={canSelectAll}
>
<TableHeader />
<TableBody />
</Table>
<DashboardWrapper hasPageTemplateTitle>
<PageSection padding={{ default: 'noPadding', xl: 'padding' }}>
<Card component="div">
<Table
gridBreakPoint="grid-xl"
header={
<React.Fragment>
<Toolbar id="page-layout-table-column-management-action-toolbar-top">{toolbarItems}</Toolbar>
</React.Fragment>
}
aria-label="This is a table with checkboxes"
Copy link
Contributor

@thatblindgeye thatblindgeye Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
aria-label="This is a table with checkboxes"
aria-label="This is a table with draggable column management"

id="page-layout-table-column-management-action-table"
onSelect={this.onSelect}
cells={columns}
rows={rows}
actions={this.actions}
canSelectAll={canSelectAll}
>
<TableHeader />
<TableBody />
</Table>
</Card>
</PageSection>
</DashboardWrapper>
<Pagination
isCompact
id="page-layout-table-column-management-action-toolbar-bottom"
Expand Down