Skip to content

refactor(Hint): Convert hint examples to typescript #7487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 2 commits into from
Jun 7, 2022
Merged

refactor(Hint): Convert hint examples to typescript #7487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39a4cae
refactor(Hint): Convert hint examples to typescript
bartoval Jun 1, 2022
6e0c2a9
refactor(Hint): update PR comments
bartoval Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
169 changes: 2 additions & 167 deletions packages/react-core/src/components/Hint/examples/Hint.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,175 +9,10 @@ propComponents: ['Hint', 'HintTitle', 'HintBody', 'HintFooter']

### Basic with title

```js
import React from 'react';
import {
Hint,
HintTitle,
HintBody,
HintFooter,
Button,
Dropdown,
DropdownToggle,
DropdownItem,
DropdownSeparator,
DropdownPosition,
DropdownDirection,
KebabToggle
} from '@patternfly/react-core';

class BasicHint extends React.Component {
constructor(props) {
super(props);
this.state = {
isOpen: false
};
this.onToggle = isOpen => {
this.setState({
isOpen
});
};
this.onSelect = event => {
this.setState({
isOpen: !this.state.isOpen
});
};
}

render() {
const { isOpen } = this.state;
const dropdownItems = [
<DropdownItem key="link">Link</DropdownItem>,
<DropdownItem key="action" component="button">
Action
</DropdownItem>,
<DropdownItem key="disabled link" isDisabled>
Disabled Link
</DropdownItem>,
<DropdownItem key="disabled action" isDisabled component="button">
Disabled Action
</DropdownItem>,
<DropdownSeparator key="separator" />,
<DropdownItem key="separated link">Separated Link</DropdownItem>,
<DropdownItem key="separated action" component="button">
Separated Action
</DropdownItem>
];
const actions = (
<Dropdown
onSelect={this.onSelect}
toggle={<KebabToggle onToggle={this.onToggle} id="hint-kebab-toggle" />}
isOpen={isOpen}
dropdownItems={dropdownItems}
position="right"
isPlain
/>
);
return (
<Hint actions={actions}>
<HintTitle>Do more with Find it Fix it capabilities</HintTitle>
<HintBody>
Upgrade to Red Hat Smart Management to remediate all your systems across regions and geographies.
</HintBody>
<HintFooter>
<Button variant="link" isInline>
Try it for 90 days
</Button>
</HintFooter>
</Hint>
);
}
}
```ts file="HintBasicWithTitle.tsx"
```

### Basic without title

```js
import React from 'react';
import {
Hint,
HintBody,
HintFooter,
Button,
Dropdown,
DropdownToggle,
DropdownItem,
DropdownSeparator,
DropdownPosition,
DropdownDirection,
KebabToggle
} from '@patternfly/react-core';

class BasicHint extends React.Component {
constructor(props) {
super(props);
this.state = {
isOpen: false
};
this.onToggle = isOpen => {
this.setState({
isOpen
});
};
this.onSelect = event => {
this.setState({
isOpen: !this.state.isOpen
});
};
}

render() {
const { isOpen } = this.state;
const dropdownItems = [
<DropdownItem key="link">Link</DropdownItem>,
<DropdownItem key="action" component="button">
Action
</DropdownItem>,
<DropdownItem key="disabled link" isDisabled>
Disabled Link
</DropdownItem>,
<DropdownItem key="disabled action" isDisabled component="button">
Disabled Action
</DropdownItem>,
<DropdownSeparator key="separator" />,
<DropdownItem key="separated link">Separated Link</DropdownItem>,
<DropdownItem key="separated action" component="button">
Separated Action
</DropdownItem>
];
const actions = (
<Dropdown
onSelect={this.onSelect}
toggle={<KebabToggle onToggle={this.onToggle} id="hint-notitle-kebab-toggle" />}
isOpen={isOpen}
dropdownItems={dropdownItems}
position="right"
isPlain
/>
);
return (
<React.Fragment>
<Hint>
<HintBody>
Welcome to the new documentation experience.
<Button variant="link" isInline>
Learn more about the improved features.
</Button>
</HintBody>
</Hint>
<br />
<Hint actions={actions}>
<HintBody>
Upgrade to Red Hat Smart Management to remediate all your systems across regions and geographies.
</HintBody>
<HintFooter>
<Button variant="link" isInline>
Try it for 90 days
</Button>
</HintFooter>
</Hint>
</React.Fragment>
);
}
}
```ts file="HintBasicWithoutTitle.tsx"
```
65 changes: 65 additions & 0 deletions packages/react-core/src/components/Hint/examples/HintBasicWithTitle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
import React from 'react';
import {
Hint,
HintTitle,
HintBody,
HintFooter,
Button,
Dropdown,
DropdownItem,
DropdownSeparator,
KebabToggle
} from '@patternfly/react-core';

export const HintBasicWithTitle: React.FunctionComponent = () => {
const [isOpen, setIsOpen] = React.useState<boolean>(false);

const onToggle = (isOpen: boolean) => {
setIsOpen(isOpen);
};

const onSelect = () => {
setIsOpen(!isOpen);
};

const dropdownItems = [
<DropdownItem key="link">Link</DropdownItem>,
<DropdownItem key="action" component="button">
Action
</DropdownItem>,
<DropdownItem key="disabled link" isDisabled>
Disabled Link
</DropdownItem>,
<DropdownItem key="disabled action" isDisabled component="button">
Disabled Action
</DropdownItem>,
<DropdownSeparator key="separator" />,
<DropdownItem key="separated link">Separated Link</DropdownItem>,
<DropdownItem key="separated action" component="button">
Separated Action
</DropdownItem>
];
const actions = (
<Dropdown
onSelect={onSelect}
toggle={<KebabToggle onToggle={onToggle} id="hint-kebab-toggle" />}
isOpen={isOpen}
dropdownItems={dropdownItems}
position="right"
isPlain
/>
);
return (
<Hint actions={actions}>
<HintTitle>Do more with Find it Fix it capabilities</HintTitle>
<HintBody>
Upgrade to Red Hat Smart Management to remediate all your systems across regions and geographies.
</HintBody>
<HintFooter>
<Button variant="link" isInline>
Try it for 90 days
</Button>
</HintFooter>
</Hint>
);
};
74 changes: 74 additions & 0 deletions packages/react-core/src/components/Hint/examples/HintBasicWithoutTitle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
import React from 'react';
import {
Hint,
HintBody,
HintFooter,
Button,
Dropdown,
DropdownItem,
DropdownSeparator,
KebabToggle
} from '@patternfly/react-core';

export const HintBasicWithoutTitle: React.FunctionComponent = () => {
const [isOpen, setIsOpen] = React.useState<boolean>(false);

const onToggle = (isOpen: boolean) => {
setIsOpen(isOpen);
};

const onSelect = () => {
setIsOpen(!isOpen);
};

const dropdownItems = [
<DropdownItem key="link">Link</DropdownItem>,
<DropdownItem key="action" component="button">
Action
</DropdownItem>,
<DropdownItem key="disabled link" isDisabled>
Disabled Link
</DropdownItem>,
<DropdownItem key="disabled action" isDisabled component="button">
Disabled Action
</DropdownItem>,
<DropdownSeparator key="separator" />,
<DropdownItem key="separated link">Separated Link</DropdownItem>,
<DropdownItem key="separated action" component="button">
Separated Action
</DropdownItem>
];
const actions = (
<Dropdown
onSelect={onSelect}
toggle={<KebabToggle onToggle={onToggle} id="hint-notitle-kebab-toggle" />}
isOpen={isOpen}
dropdownItems={dropdownItems}
position="right"
isPlain
/>
);
return (
<React.Fragment>
<Hint>
<HintBody>
Welcome to the new documentation experience.
<Button variant="link" isInline>
Learn more about the improved features.
</Button>
</HintBody>
</Hint>
<br />
<Hint actions={actions}>
<HintBody>
Upgrade to Red Hat Smart Management to remediate all your systems across regions and geographies.
</HintBody>
<HintFooter>
<Button variant="link" isInline>
Try it for 90 days
</Button>
</HintFooter>
</Hint>
</React.Fragment>
);
};