chore(InputGroup): convert examples to TypeScript #7493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-7493.surge.sh A11y report: https://patternfly-react-pr-7493-a11y.surge.sh |
tompsota
force-pushed
the
inputGroup_to_typescript
branch
from
3bbf002 to
52e5348
Compare
thatblindgeye
requested changes
Jun 1, 2022
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Things are looking good! Just had a couple of suggested changes and one comment that I tagged Titani for input on.
packages/react-core/src/components/InputGroup/examples/InputGroupBasic.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/InputGroup/examples/InputGroupWithDropdown.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/InputGroup/examples/InputGroupWithDropdown.tsx
Outdated
Show resolved
Hide resolved
tompsota
force-pushed
the
inputGroup_to_typescript
branch
from
52e5348 to
1bc01a0
Compare
nicolethoen
reviewed
Jun 8, 2022
| setIsOpen(isOpen); | ||
| }; | ||
|
|
||
| const onSelect = event => { |
Contributor
There was a problem hiding this comment.
If you keep this function after addressing eric's comment, could you add a type to the params of functions you pass to components? This helps us sanity check that our component props are typed correctly and also helps communicate types easier to people using the component.
tlabaj
requested changes
Jun 13, 2022
packages/react-core/src/components/InputGroup/examples/InputGroupWithDropdown.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomas Psota <tpsota@redhat.com>
tompsota
force-pushed
the
inputGroup_to_typescript
branch
from
1bc01a0 to
52b0ce9
Compare
thatblindgeye
approved these changes
Jun 15, 2022
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
🎉 looks good! Great work on this
nicolethoen
approved these changes
Jun 15, 2022
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomas Psota tpsota@redhat.com
What: Closes #7490