chore(Expandable Section): convert examples to TypeScript #7506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-7506.surge.sh A11y report: https://patternfly-react-pr-7506-a11y.surge.sh |
thatblindgeye
approved these changes
Jun 3, 2022
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Looks good! Had a minor nitpick below, but it's more personal preference I think and not something I'd block over.
| import { ExpandableSection, Badge } from '@patternfly/react-core'; | ||
| import CheckCircleIcon from '@patternfly/react-icons/dist/esm/icons/check-circle-icon'; | ||
|
|
||
| export const ExpandableSectionCustom: React.FunctionComponent = () => { |
Contributor
There was a problem hiding this comment.
Nitpick: the file name + exported name could instead be ExpandableSectionCustomToggle to provide more context of the example.
nicolethoen
approved these changes
Jun 8, 2022
jenny-s51
commented
Jun 8, 2022
Contributor
Author
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
Thank you @thatblindgeye! Renamed the custom toggle demo per your feedback
thatblindgeye
approved these changes
Jun 8, 2022
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
🎉 Approving again for the latest update
nicolethoen
approved these changes
Jun 10, 2022
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #7455