chore(List): converted all examples to typescript #7550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-7550.surge.sh A11y report: https://patternfly-react-pr-7550-a11y.surge.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #7549 . List examples have all been converted from JS to TS.
Additional issues: This is not a critical issue. However, when writing out the TS examples for ListIcons.tsx and ListLargeIcons.tsx, there was an error on line 6110 of
node_modules/typescript/lib/typescript.jsregardingreplacebeing undefined in thenormalizeSlashesfunction. This was solved by changing the name of the imports of the icons fromBookOpentoBookOpenIconin both the markdown and the TS file, which works since the icons are export default. I'm not entirely sure as to what was going on but this issue was resolved with that solution.