Skip to content

Conversation

@tompsota
Copy link
Contributor

Signed-off-by: Tomas Psota tpsota@redhat.com

What: Closes #7494

@patternfly-build
Copy link
Collaborator

patternfly-build commented Jun 15, 2022

Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great @tompsota - nice work! Just a couple nits about the file and function names in order to make them a bit clearer 🙂

Otherwise LGTM!

Signed-off-by: Tomas Psota <tpsota@redhat.com>
@tompsota tompsota force-pushed the jumplinks_to_typescript branch from fc081f8 to 22779bb Compare June 15, 2022 14:41
Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks 💯

@nicolethoen nicolethoen merged commit b047996 into patternfly:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert Jump links examples to typescript

5 participants