chore(Modal): convert examples to TypeScript #7579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-7579.surge.sh A11y report: https://patternfly-react-pr-7579-a11y.surge.sh |
thatblindgeye
force-pushed
the
modal_conversion
branch
from
64d3683 to
1fdf7cd
Compare
jenny-s51
approved these changes
Jun 30, 2022
nicolethoen
approved these changes
Jul 5, 2022
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
jenny-s51
pushed a commit
to jenny-s51/patternfly-react
that referenced
this pull request
Jul 26, 2022
* chore(Modal): convert examples to TypeScript * Convert remaining examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #7574
For the examples "custom header and footer" and "no header", I updated some verbiage about the
spanthat acts as the description of the modal. For the "custom header/footer" example I removed thearia-labelprop from the example; while it did announce both the aria-label and aria-labelledby in Safari, the use of aria-label in the example didn't seem needed.I also updated the "warning alert" example name to just "Title icon", to flow into the "custom title icon" example.
Additional issues: