Skip to content

Conversation

@kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Jul 21, 2022

What: Closes #7617

  • Adds new examples showing vertical and center alignment working together for basic and compact progress stepper.
  • Converts examples to TSX.
  • Also adjusts examples to cut down on page length (combining the 3 separate alignment examples into a single alignment example with flags for basic and a single compact example for compact). If we want these use cases (vertical only, center only, vertical and center together) to be separate examples I still have them stashed locally and can adjust them back.

@patternfly-build
Copy link
Collaborator

patternfly-build commented Jul 21, 2022

Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @nicolethoen !

Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic, nice work! 👍

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! For the following files listed, they're missing the export....: React.FunctionComponent syntax:

  • ProgressStepperBasic
  • ProgressStepperBasicFailure
  • ProgressStepperBasicIssue
  • ProgressStepperBasicWithDescription
  • ProgressStepperIcons

@nicolethoen nicolethoen merged commit 6b20493 into patternfly:main Jul 27, 2022
@patternfly-build
Copy link
Collaborator

Your changes have been released in:

  • eslint-plugin-patternfly-react@4.66.2
  • @patternfly/react-catalog-view-extension@4.78.2
  • @patternfly/react-charts@6.80.2
  • @patternfly/react-code-editor@4.68.2
  • @patternfly/react-console@4.78.2
  • @patternfly/react-core@4.227.2
  • @patternfly/react-docs@5.88.2
  • @patternfly/react-icons@4.78.2
  • @patternfly/react-inline-edit-extension@4.72.2
  • demo-app-ts@4.187.2
  • @patternfly/react-integration@4.189.2
  • @patternfly/react-log-viewer@4.72.2
  • @patternfly/react-styles@4.77.2
  • @patternfly/react-table@4.96.2
  • @patternfly/react-tokens@4.79.2
  • @patternfly/react-topology@4.74.2
  • @patternfly/react-virtualized-extension@4.74.2
  • transformer-cjs-imports@4.65.2

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Progress stepper - responsive behavior for horizontal progress stepper

6 participants