-
Notifications
You must be signed in to change notification settings - Fork 377
docs(ProgressStepper): add examples to show alignment modifiers working together #7727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview: https://patternfly-react-pr-7727.surge.sh A11y report: https://patternfly-react-pr-7727-a11y.surge.sh |
mcarrano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @nicolethoen !
mattnolting
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic, nice work! 👍
thatblindgeye
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! For the following files listed, they're missing the export....: React.FunctionComponent syntax:
- ProgressStepperBasic
- ProgressStepperBasicFailure
- ProgressStepperBasicIssue
- ProgressStepperBasicWithDescription
- ProgressStepperIcons
packages/react-core/src/components/ProgressStepper/examples/ProgressStepperHelpPopover.tsx
Show resolved
Hide resolved
packages/react-core/src/components/ProgressStepper/examples/ProgressStepperIcons.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/ProgressStepper/examples/ProgressStepperBasic.tsx
Show resolved
Hide resolved
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #7617