Update to React Router v5 for the demo app #7826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
Collaborator
|
Preview: https://patternfly-react-pr-7826.surge.sh A11y report: https://patternfly-react-pr-7826-a11y.surge.sh |
kmcfaul
approved these changes
Aug 17, 2022
jeff-phillips-18
approved these changes
Aug 17, 2022
Member
jeff-phillips-18
left a comment
jeff-phillips-18
left a comment
There was a problem hiding this comment.
LGTM, verified navigation works as before.
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works towards closing #7142. Updates React Router to version 5 for the demo app to ensure compatibility with React 18. This change is completely backwards compatible.