Skip to content

chore(Progress) convert examples to TypeScript #7837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tlabaj merged 2 commits into from
Aug 18, 2022
Merged

chore(Progress) convert examples to TypeScript #7837

tlabaj merged 2 commits into from
Aug 18, 2022

Conversation

@dominik-petrik
Copy link
Contributor

@dominik-petrik dominik-petrik commented Aug 16, 2022

What: Closes #7836

@patternfly-build
Copy link
Collaborator

patternfly-build commented Aug 16, 2022 •
edited
Loading

Preview: https://patternfly-react-pr-7837.surge.sh

A11y report: https://patternfly-react-pr-7837-a11y.surge.sh

thatblindgeye
thatblindgeye reviewed Aug 17, 2022
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Had a couple quick suggested edits and a nitpick below, let me know what you think!

packages/react-core/src/components/Progress/examples/Progress.md Outdated
```ts file="./ProgressFiniteStep.tsx"
```

### Progress (step instruction)
Copy link
Contributor

@thatblindgeye thatblindgeye Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of a nitpick, so not a blocker if the example title is kept as-is:

Suggested change
### Progress (step instruction)
### Progress with step instruction

packages/react-core/src/components/Progress/examples/ProgressTitleOutsideOfProgressBar.tsx Outdated
export const ProgressTitleOutsideOfProgressBar: React.FunctionComponent = () => (
<DescriptionList>
<DescriptionListGroup>
<DescriptionListTerm id="progress-label">Title outside of progress bar</DescriptionListTerm>
Copy link
Contributor

@thatblindgeye thatblindgeye Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of an "in case" thing, but just to prevent any issues in the future with duplicate IDs:

Suggested change
<DescriptionListTerm id="progress-label">Title outside of progress bar</DescriptionListTerm>
<DescriptionListTerm id="title-outside-progress-example-label">Title outside of progress bar</DescriptionListTerm>

packages/react-core/src/components/Progress/examples/ProgressTitleOutsideOfProgressBar.tsx Outdated
<DescriptionListGroup>
<DescriptionListTerm id="progress-label">Title outside of progress bar</DescriptionListTerm>
<DescriptionListDescription>
<Progress value={33} measureLocation={ProgressMeasureLocation.outside} aria-labelledby="progress-label" />
Copy link
Contributor

@thatblindgeye thatblindgeye Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Progress value={33} measureLocation={ProgressMeasureLocation.outside} aria-labelledby="progress-label" />
<Progress value={33} measureLocation={ProgressMeasureLocation.outside} aria-labelledby="title-outside-progress-example-label" />

Copy link
Contributor Author

@dominik-petrik dominik-petrik Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! All the required changes have been made. Let me know if there is anything more that needs to be done!

thatblindgeye
thatblindgeye approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates! 🎉

@tlabaj tlabaj merged commit 44bdae8 into patternfly:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlabaj tlabaj tlabaj approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Progress: convert examples to TypeScript

5 participants

@dominik-petrik @patternfly-build @tlabaj @kmcfaul @thatblindgeye