docs(Alert, calendar month, code editor, date picker) - add sub component descriptions #7974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-7974.surge.sh A11y report: https://patternfly-react-pr-7974-a11y.surge.sh |
thatblindgeye
force-pushed
the
alert_sub-comp_desc
branch
from
0602019 to
5d61c6b
Compare
nicolethoen
reviewed
Sep 20, 2022
packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx
Outdated
Show resolved
Hide resolved
thatblindgeye
force-pushed
the
alert_sub-comp_desc
branch
from
5d61c6b to
1369750
Compare
nicolethoen
approved these changes
Sep 21, 2022
thatblindgeye
force-pushed
the
alert_sub-comp_desc
branch
from
1369750 to
a1b4f11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #7973
Tried using general verbiage for the CalendarFormat and Popover descriptions, since those are used in multiple components.
In particular I could use some eyes on the DatePickerRef description to see if it matches the intention of that interface.
Also reordered props alphabetically.
Additional issues: