chore(Title): Convert examples to TypeScript #7999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-7999.surge.sh A11y report: https://patternfly-react-pr-7999-a11y.surge.sh |
thatblindgeye
requested changes
Sep 19, 2022
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Awesome work on this! I just had some comments below.
Additionally I do like the update regarding the "custom sizes". To build off of that, would you also mind updating the example titles ("Custom sizes" and "Default sizes" instead of "Sizes" and "Default size mappings"), and reorder the examples so that the "default" example comes first?
packages/react-core/src/components/Title/examples/TitleDefaultSizes.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Title/examples/TitleSizes.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Title/examples/TitleDefaultSizes.tsx
Outdated
Show resolved
Hide resolved
gefgu
force-pushed
the
chore/convert-title-examples-to-ts
branch
from
a209165 to
cf7072a
Compare
Contributor
Author
|
@thatblindgeye your feedback is superb!! Already implemented the changes. Thanks for making open-source such an amazing learning journey. Excited to keep learning... |
thatblindgeye
approved these changes
Sep 20, 2022
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
🎉 thanks for making these updates! 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #7997
Convert Title examples to TypeScript.
Additional issues: