Skip to content

Create "deprecated" subpaths in react-table #8381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 3 commits into from
Dec 1, 2022
Merged

Create "deprecated" subpaths in react-table #8381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f448bd9
change base to main
jenny-s51 Nov 21, 2022
8bfaca9
revert index.ts change
jenny-s51 Nov 21, 2022
2186d91
Update patternfly-docs.source.js
jenny-s51 Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/react-docs/patternfly-docs/patternfly-docs.source.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,12 @@ module.exports = (baseSourceMD, sourceProps) => {
sourceMD(path.join(reactCorePath, '/**/demos/**/*.md'), 'react-demos');

// React-table MD
sourceMD(path.join(reactTablePath, '/**/TableComposable/examples/*.md'), 'react-composable');
sourceMD(path.join(reactTablePath, '/**/demos/*.md'), 'react-demos');
sourceMD(path.join(reactTablePath, '/**/TableComposable/examples/*.md'), 'react');
sourceMD(path.join(reactTablePath, '/**/Table/examples/*.md'), 'react-legacy');
// TODO: uncomment once https://github.com/patternfly/patternfly-org/pull/3291 is reviewed + merged
Copy link
Contributor

@tlabaj tlabaj Dec 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please open an issue for this so we do not loose track.

// sourceMD(path.join(reactTablePath,
// sourceMD(path.join(reactTablePath, '/deprecated/components/**/examples/*.md'), 'react-deprecated');
sourceMD(path.join(reactTablePath, '/**/demos/*.md'), 'react-demos');

// Charts MD (no demos yet)
sourceMD(path.join(reactChartsPath, '/**/examples/*.md'), 'react');
Expand Down
10 changes: 10 additions & 0 deletions packages/react-table/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,16 @@
"main": "dist/js/index.js",
"module": "dist/esm/index.js",
"types": "dist/esm/index.d.ts",
"exports": {
".": "./dist/esm/index.js",
"./deprecated": "./dist/esm/deprecated/index.js",
"./package.json": "./package.json"
},
"typesVersions": {
"*": {
"deprecated": ["dist/esm/deprecated/index.d.ts"]
}
},
"patternfly:src": "src/",
"sideEffects": false,
"publishConfig": {
Expand Down
1 change: 1 addition & 0 deletions packages/react-table/src/deprecated/components/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './';
1 change: 1 addition & 0 deletions packages/react-table/src/deprecated/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './components';
6 changes: 5 additions & 1 deletion packages/react-table/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@
"compilerOptions": {
"rootDir": "./src",
"outDir": "./dist/esm",
"tsBuildInfoFile": "dist/esm.tsbuildinfo"
"tsBuildInfoFile": "dist/esm.tsbuildinfo",
"baseUrl": ".",
"paths": {
"*/deprecated": ["./src/deprecated"],
}
},
"include": [
"./src/*",
Expand Down