fix(NumberInput): make allowEmptyInput an opt-in prop

packages/react-core/src/components/NumberInput/NumberInput.tsx

@@ -51,6 +51,8 @@ export interface NumberInputProps extends React.HTMLProps<HTMLDivElement> {
   minusBtnProps?: ButtonProps;
   /** Additional properties added to the plus button */
   plusBtnProps?: ButtonProps;
+  /** Allow the user to clear out the input to an empty string (recommended) */
+  allowEmptyInput?: boolean;
 }
 
 type DefaultKeyDownHandlerArgs = Pick<NumberInputProps, 'inputName' | 'onMinus' | 'onPlus'>;
@@ -87,8 +89,12 @@ export const NumberInput: React.FunctionComponent<NumberInputProps> = ({
   inputProps,
   minusBtnProps,
   plusBtnProps,
+  allowEmptyInput = false,
   ...props
 }: NumberInputProps) => {
+  if (!allowEmptyInput) {
+    value = value || 0;
+  }
   const numberInputUnit = <div className={css(styles.numberInputUnit)}>{unit}</div>;
   const keyDownHandler =
     inputProps && inputProps.onKeyDown ? inputProps.onKeyDown : defaultKeyDownHandler({ inputName, onMinus, onPlus });

packages/react-core/src/components/NumberInput/__tests__/NumberInput.test.tsx

@@ -207,9 +207,15 @@ describe('numberInput', () => {
     expect(input).toHaveDisplayValue('0');
   });
 
-  test('renders nothing if null value passed', () => {
+  test('renders 0 if null value passed without allow empty', () => {
     render(<NumberInput value={null} />);
     const input = screen.getByRole('spinbutton');
+    expect(input).toHaveDisplayValue('0');
+  });
+
+  test('renders nothing if null value passed with allow empty', () => {
+    render(<NumberInput allowEmptyInput value={null} />);
+    const input = screen.getByRole('spinbutton');
     expect(input).toHaveDisplayValue('');
   });
 

packages/react-core/src/components/NumberInput/examples/NumberInputCustomStep.tsx

@@ -24,6 +24,7 @@ export const NumberInputCustomStep: React.FunctionComponent = () => {
       inputAriaLabel="number input"
       minusBtnAriaLabel="minus"
       plusBtnAriaLabel="plus"
+      allowEmptyInput
     />
   );
 };

packages/react-core/src/components/NumberInput/examples/NumberInputCustomStepAndThreshold.tsx

@@ -46,6 +46,7 @@ export const NumberInputCustomStepAndThreshold: React.FunctionComponent = () =>
       inputAriaLabel="number input"
       minusBtnAriaLabel="minus"
       plusBtnAriaLabel="plus"
+      allowEmptyInput
     />
   );
 };

packages/react-core/src/components/NumberInput/examples/NumberInputDefault.tsx

@@ -29,6 +29,7 @@ export const NumberInputDefault: React.FunctionComponent = () => {
       inputAriaLabel="number input"
       minusBtnAriaLabel="minus"
       plusBtnAriaLabel="plus"
+      allowEmptyInput
     />
   );
 };

packages/react-core/src/components/NumberInput/examples/NumberInputDisabled.tsx

@@ -35,6 +35,7 @@ export const NumberInputDisabled: React.FunctionComponent = () => {
       plusBtnAriaLabel="plus"
       unit="%"
       isDisabled
+      allowEmptyInput
     />
   );
 };

packages/react-core/src/components/NumberInput/examples/NumberInputUnit.tsx

@@ -37,6 +37,7 @@ export const NumberInputUnit: React.FunctionComponent = () => {
         minusBtnAriaLabel="minus 1"
         plusBtnAriaLabel="plus 1"
         unit="%"
+        allowEmptyInput
       />
       <br />
       <br />
@@ -51,6 +52,7 @@ export const NumberInputUnit: React.FunctionComponent = () => {
         plusBtnAriaLabel="plus 0.01"
         unit="$"
         unitPosition="before"
+        allowEmptyInput
       />
     </React.Fragment>
   );

packages/react-core/src/components/NumberInput/examples/NumberInputUnitThreshold.tsx

@@ -59,6 +59,7 @@ export const NumberInputUnitThreshold: React.FunctionComponent = () => {
         minusBtnAriaLabel="minus"
         plusBtnAriaLabel="plus"
         unit="%"
+        allowEmptyInput
       />
     </React.Fragment>
   );

packages/react-core/src/components/NumberInput/examples/NumberInputVaryingSizes.tsx

@@ -35,6 +35,7 @@ export const NumberInputVaryingSizes: React.FunctionComponent = () => {
         minusBtnAriaLabel="input 2 minus"
         plusBtnAriaLabel="input 2 plus"
         widthChars={1}
+        allowEmptyInput
       />
       <br />
       <br />
@@ -48,6 +49,7 @@ export const NumberInputVaryingSizes: React.FunctionComponent = () => {
         minusBtnAriaLabel="input 2 minus"
         plusBtnAriaLabel="input 2 plus"
         widthChars={10}
+        allowEmptyInput
       />
       <br />
       <br />
@@ -61,6 +63,7 @@ export const NumberInputVaryingSizes: React.FunctionComponent = () => {
         minusBtnAriaLabel="input 3 minus"
         plusBtnAriaLabel="input 3 plus"
         widthChars={5}
+        allowEmptyInput
       />
       <br />
       <br />
@@ -74,6 +77,7 @@ export const NumberInputVaryingSizes: React.FunctionComponent = () => {
         minusBtnAriaLabel="input 4 minus"
         plusBtnAriaLabel="input 4 plus"
         widthChars={5}
+        allowEmptyInput
       />
     </React.Fragment>
   );

packages/react-core/src/components/NumberInput/examples/NumberInputWithStatus.tsx

@@ -53,6 +53,7 @@ export const NumberInputWithStatus: React.FunctionComponent = () => {
         inputAriaLabel="number input"
         minusBtnAriaLabel="minus"
         plusBtnAriaLabel="plus"
+        allowEmptyInput
       />
     </>
   );

packages/react-core/src/demos/examples/AlertGroup/AlertGroupToastWithNotificationDrawer.tsx

@@ -344,6 +344,7 @@ export const AlertGroupToastWithNotificationDrawer: React.FunctionComponent = ()
           minusBtnAriaLabel="minus"
           plusBtnAriaLabel="plus"
           style={{ margin: '12px 0' }}
+          allowEmptyInput
         />
       </PageSection>
       <PageSection variant={PageSectionVariants.light}>

packages/react-integration/demo-app-ts/src/components/demos/NumberInputDemo/NumberInputDemo.tsx

@@ -87,6 +87,7 @@ export class NumberInputDemo extends Component<NumberInputDemoState> {
           plusBtnProps={{ id: 'plus-button' }}
           unit="%"
           widthChars={5}
+          allowEmptyInput
         />
         <br />
         <br />
@@ -108,6 +109,7 @@ export class NumberInputDemo extends Component<NumberInputDemoState> {
           unit="$"
           unitPosition="before"
           isDisabled
+          allowEmptyInput
         />
         <br />
         <br />
@@ -129,6 +131,7 @@ export class NumberInputDemo extends Component<NumberInputDemoState> {
           plusBtnProps={{ id: 'plus-button3' }}
           unit="$"
           unitPosition="before"
+          allowEmptyInput
         />
       </React.Fragment>
     );