Skip to content

fix(LabelGroup): show the correct count of overflow labels #8505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 1 commit into from
Jan 11, 2023
Merged

fix(LabelGroup): show the correct count of overflow labels #8505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions packages/react-core/src/components/LabelGroup/LabelGroup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,15 +156,14 @@ export class LabelGroup extends React.Component<LabelGroupProps, LabelGroupState
...rest
} = this.props;
const { isOpen } = this.state;
const numChildren = React.Children.count(children);
const renderedChildren = React.Children.toArray(children);
const numChildren = renderedChildren.length;
const collapsedTextResult = fillTemplate(collapsedText as string, {
remaining: React.Children.count(children) - numLabels
remaining: numChildren - numLabels
});

const renderLabelGroup = (id: string) => {
const labelArray = !isOpen
? React.Children.toArray(children).slice(0, numLabels)
: React.Children.toArray(children);
const labelArray = !isOpen ? renderedChildren.slice(0, numLabels) : renderedChildren;

const content = (
<React.Fragment>
Expand Down