Skip to content

Conversation

@thatblindgeye
Copy link
Contributor

What: Closes #9237

We could instead update Popover's position prop to "auto", which would cause it to reposition before scrolling, though there may still be an issue of it getting cut off by a masthead depending on the layout.

There were also some other components that might be affected (menu like components), but since they don't use a focus trap like Popover does, I'm hesitent to revert those appendTo props to document body. Those could also have scrollbars to reduce the height and avoid the issue, though I don't believe the new dropdown/select currently can be passed the necessary props to achieve that (could be a followup for after v5)

Additional issues:

@thatblindgeye thatblindgeye requested review from kmcfaul and tlabaj June 7, 2023 17:57
@patternfly-build
Copy link
Collaborator

patternfly-build commented Jun 7, 2023

Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Dropdown/Select should allow any popper property to be passed through popperProps because it is spread directly to Popper. It's a little confusing because those interfaces aren't really functioning as an interface so much as a hook + mask for our docgen. We may want to enforce those interfaces better, and/or expose more props on them.

Everything here lgtm.

@tlabaj
Copy link
Contributor

tlabaj commented Jun 8, 2023

The Dropdown/Select should allow any popper property to be passed through popperProps because it is spread directly to Popper. It's a little confusing because those interfaces aren't really functioning as an interface so much as a hook + mask for our docgen. We may want to enforce those interfaces better, and/or expose more props on them.

Everything here lgtm.

@kmcfaul can you open up a follow up issue/spike for this.

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tlabaj tlabaj merged commit f2b140d into patternfly:main Jun 8, 2023
nicolethoen pushed a commit to Kells512/patternfly-react that referenced this pull request Sep 1, 2023
* fix(Popover): reverted appendTo to document body

* Updated verbiage in example file

* Bumped reactcore version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - v5 alpha testing - Popover enableFlip

5 participants