fix(Popover): reverted appendTo to document body #9252
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9237
We could instead update Popover's
positionprop to "auto", which would cause it to reposition before scrolling, though there may still be an issue of it getting cut off by a masthead depending on the layout.There were also some other components that might be affected (menu like components), but since they don't use a focus trap like Popover does, I'm hesitent to revert those appendTo props to document body. Those could also have scrollbars to reduce the height and avoid the issue, though I don't believe the new dropdown/select currently can be passed the necessary props to achieve that (could be a followup for after v5)
Additional issues: