Skip to content

fix(AlertActionLink) support ReactNode as child #9278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 4 commits into from
Jul 26, 2023
Merged

fix(AlertActionLink) support ReactNode as child #9278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a799a2
fix(AlertActionLink) support ReactNode as child
dominik-petrik Jun 16, 2023
6e61618
add test
dominik-petrik Jun 19, 2023
408cf4b
update prop type and description
dominik-petrik Jul 7, 2023
184e4ca
update test
dominik-petrik Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-core/src/components/Alert/AlertActionLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import { Button, ButtonVariant, ButtonProps } from '../Button';
*/

export interface AlertActionLinkProps extends ButtonProps {
/** Content rendered inside the alert action link. */
children?: string;
/** Content rendered inside the alert action link. Interactive content such as anchor elements should not be passed in. */
children?: React.ReactNode;
/** Additional classes added to the alert action link. */
className?: string;
}
Expand Down
12 changes: 12 additions & 0 deletions packages/react-core/src/components/Alert/__tests__/AlertActionLink.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,18 @@ test('Renders children', () => {
expect(screen.getByRole('button')).toBeVisible();
});

test('Renders ReactNode as children', () => {
render(
<AlertActionLink>
<div>
<span>Learn More</span>
</div>
</AlertActionLink>
);

expect(screen.getByText('Learn More')).toBeVisible();
});

test('Renders with custom class names provided via prop', () => {
render(<AlertActionLink className="custom-class">Test</AlertActionLink>);

Expand Down