Skip to content

fix(Popper): fixed flicker when opening popper content #9339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 3 commits into from
Aug 1, 2023
Merged

fix(Popper): fixed flicker when opening popper content #9339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b83d7a8
fix(Popper): fixed flicker when opening popper content
wise-king-sullyman Jul 6, 2023
3b58c39
fixed re-focus delay when closing popover
wise-king-sullyman Jul 10, 2023
c54f919
updated DatePicker test to have consistent value
wise-king-sullyman Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/src/components/DataList/__tests__/__snapshots__/DataList.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ exports[`DataList DataListAction dropdown 1`] = `
data-ouia-component-id="OUIA-Generated-Dropdown-1"
data-ouia-component-type="PF5/Dropdown"
data-ouia-safe="true"
style="position: absolute; left: 0px; top: 0px; z-index: 9999;"
style="position: absolute; left: 0px; top: 0px; z-index: 9999; opacity: 0; transition: opacity 0ms cubic-bezier(.54, 1.5, .38, 1.11);"
>
<div
class="pf-v5-c-menu__content"
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/DatePicker/__tests__/DatePicker.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ test('Error state can be cleared from outside', async () => {
test('With popover opened', async () => {
const user = userEvent.setup();

const { asFragment } = render(<DatePicker />);
const { asFragment } = render(<DatePicker value="2020-03-17" />);

await user.click(screen.getByRole('button', { name: 'Toggle date picker' }));
await screen.findByRole('button', { name: 'Previous month' });
Expand Down
Loading