Skip to content

chore: update breadcrumb dropdown item arrow to work in RTL #9603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 2 commits into from
Sep 21, 2023
Merged

chore: update breadcrumb dropdown item arrow to work in RTL #9603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e3a16c
chore: update breadcrumb dropdown item arrow to work in RTL
mcoker Sep 12, 2023
53bcbdb
chore: use icon with shouldMirrorRTL instead
mcoker Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions packages/react-core/src/components/Breadcrumb/examples/BreadcrumbDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,42 @@ import {
Dropdown,
DropdownList,
DropdownItem,
Icon,
MenuToggle,
MenuToggleElement
} from '@patternfly/react-core';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import CaretDownIcon from '@patternfly/react-icons/dist/esm/icons/caret-down-icon';

const dropdownItems = [
<DropdownItem icon={<AngleLeftIcon />} key="edit">
<DropdownItem
icon={
<Icon shouldMirrorRTL>
<AngleLeftIcon />
</Icon>
}
key="edit"
>
Edit
</DropdownItem>,
<DropdownItem icon={<AngleLeftIcon />} key="action">
<DropdownItem
icon={
<Icon shouldMirrorRTL>
<AngleLeftIcon />
</Icon>
}
key="action"
>
Deployment
</DropdownItem>,
<DropdownItem icon={<AngleLeftIcon />} key="apps">
<DropdownItem
icon={
<Icon shouldMirrorRTL>
<AngleLeftIcon />
</Icon>
}
key="apps"
>
Applications
</DropdownItem>
];
Expand Down
47 changes: 32 additions & 15 deletions packages/react-core/src/components/Menu/examples/MenuWithDrilldownBreadcrumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,23 @@
import React from 'react';
import {
Menu,
MenuContent,
MenuList,
MenuItem,
Divider,
DrilldownMenu,
Badge,
Breadcrumb,
BreadcrumbItem,
BreadcrumbHeading,
MenuBreadcrumb,
BreadcrumbItem,
Checkbox,
Divider,
DrilldownMenu,
Dropdown,
DropdownList,
DropdownItem,
DropdownList,
Icon,
Menu,
MenuBreadcrumb,
MenuContent,
MenuItem,
MenuList,
MenuToggle,
MenuToggleElement,
Badge
MenuToggleElement
} from '@patternfly/react-core';
import StorageDomainIcon from '@patternfly/react-icons/dist/esm/icons/storage-domain-icon';
import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
Expand Down Expand Up @@ -129,7 +130,11 @@ export const MenuWithDrilldownBreadcrumbs: React.FunctionComponent = () => {
<DropdownList>
<DropdownItem
key="dropdown-start"
icon={<AngleLeftIcon />}
icon={
<Icon shouldMirrorRTL>
<AngleLeftIcon />
</Icon>
}
onClick={(event: any) =>
drillOut(event, 'breadcrumbs-drilldownMenuStart', 'group:app_grouping_start', startRolloutBreadcrumb)
}
Expand Down Expand Up @@ -169,7 +174,11 @@ export const MenuWithDrilldownBreadcrumbs: React.FunctionComponent = () => {
<DropdownList>
<DropdownItem
key="dropdown-start"
icon={<AngleLeftIcon />}
icon={
<Icon shouldMirrorRTL>
<AngleLeftIcon />
</Icon>
}
onClick={(event: any) =>
drillOut(event, 'breadcrumbs-drilldownMenuStart', 'group:labels_start', startRolloutBreadcrumb)
}
Expand Down Expand Up @@ -221,7 +230,11 @@ export const MenuWithDrilldownBreadcrumbs: React.FunctionComponent = () => {
<DropdownList>
<DropdownItem
key="dropdown-pause"
icon={<AngleLeftIcon />}
icon={
<Icon shouldMirrorRTL>
<AngleLeftIcon />
</Icon>
}
onClick={(event: any) =>
drillOut(event, 'breadcrumbs-drilldownMenuPause', 'group:app_grouping', pauseRolloutsBreadcrumb)
}
Expand Down Expand Up @@ -266,7 +279,11 @@ export const MenuWithDrilldownBreadcrumbs: React.FunctionComponent = () => {
<DropdownList>
<DropdownItem
key="dropdown-pause"
icon={<AngleLeftIcon />}
icon={
<Icon shouldMirrorRTL>
<AngleLeftIcon />
</Icon>
}
onClick={(event: any) =>
drillOut(event, 'breadcrumbs-drilldownMenuPause', 'group:labels', pauseRolloutsBreadcrumb)
}
Expand Down