fix(Popover, Tooltip): fix arrow positioning in RTL #9638
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-9638.surge.sh A11y report: https://patternfly-react-pr-9638-a11y.surge.sh |
thatblindgeye
approved these changes
Sep 19, 2023
Collaborator
Author
|
An alternative core based solution is being explored which may make this PR unneeded. |
kmcfaul
approved these changes
Sep 21, 2023
Contributor
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
In case the PR is needed, lgtm
Collaborator
Author
|
Issue was resolved by patternfly/patternfly#5952 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9608
Should be merged after #9628 as it includes changes from that PR.
Changes in this PR start at ec3b15b