Skip to content

fix(Popover): click event trigger logic #9952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 1 commit into from
Jan 10, 2024
Merged

fix(Popover): click event trigger logic #9952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/react-core/src/components/Popover/Popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,10 +334,10 @@ export const Popover: React.FunctionComponent<PopoverProps> = ({
};
const onDocumentClick = (event: MouseEvent, triggerElement: HTMLElement, popperElement: HTMLElement) => {
if (hideOnOutsideClick && visible) {
// check if we clicked within the popper, if so don't do anything
const isChild = popperElement && popperElement.contains(event.target as Node);
if (isChild) {
// clicked within the popper
const isFromChild = popperElement && popperElement.contains(event.target as Node);
const isFromTrigger = triggerElement && triggerElement.contains(event.target as Node);
if (isFromChild || isFromTrigger) {
// if clicked within the popper or on the trigger, ignore this event
return;
}
if (triggerManually) {
Expand Down