Skip to content

Conversation

@tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Jan 10, 2024

What: Closes #9844
About modal convenience link https://patternfly-react-pr-9957.surge.sh/components/about-modal

Please also verify the Penta Modal is correct https://patternfly-react-pr-9957.surge.sh/components/modal

@tlabaj tlabaj requested review from a team, kmcfaul, mattnolting and wise-king-sullyman and removed request for a team January 10, 2024 20:20
@tlabaj tlabaj linked an issue Jan 10, 2024 that may be closed by this pull request
@patternfly-build
Copy link
Collaborator

patternfly-build commented Jan 10, 2024

@lboehling
Copy link
Collaborator

lgtm!

@andrew-ronaldson andrew-ronaldson self-requested a review January 12, 2024 16:34
Copy link
Collaborator

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-01-12 at 12 34 37 PM
When the modal opens the x Close button has the hover state applied.

Copy link
Collaborator

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@gitdallas gitdallas merged commit 34a721e into patternfly:v6 Jan 19, 2024
@patternfly-build
Copy link
Collaborator

Your changes have been released in:

  • @patternfly/react-code-editor@6.0.0-alpha.17
  • @patternfly/react-core@6.0.0-alpha.17
  • @patternfly/react-docs@7.0.0-alpha.18
  • demo-app-ts@5.1.1-alpha.16
  • @patternfly/react-table@6.0.0-alpha.17

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consume core updates: Modal and About Modal (Follow up to issue)

8 participants