chore(About modal): Update logos in about modal examples #9957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlabaj
requested review from
a team,
kmcfaul,
mattnolting and
wise-king-sullyman
and removed request for
a team
Collaborator
|
Preview: https://patternfly-react-pr-9957.surge.sh A11y report: https://patternfly-react-pr-9957-a11y.surge.sh |
wise-king-sullyman
approved these changes
Jan 12, 2024
Collaborator
|
lgtm! |
Collaborator
andrew-ronaldson
left a comment
andrew-ronaldson
left a comment
There was a problem hiding this comment.
When the modal opens the x Close button has the hover state applied.
thatblindgeye
approved these changes
Jan 12, 2024
gitdallas
approved these changes
Jan 19, 2024
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9844
About modal convenience link https://patternfly-react-pr-9957.surge.sh/components/about-modal
Please also verify the Penta Modal is correct https://patternfly-react-pr-9957.surge.sh/components/modal