feat(Pagination): applied Penta updates#9971
Merged
wise-king-sullyman merged 4 commits intopatternfly:v6from Jan 18, 2024
Merged
feat(Pagination): applied Penta updates#9971wise-king-sullyman merged 4 commits intopatternfly:v6from
wise-king-sullyman merged 4 commits intopatternfly:v6from
Conversation
thatblindgeye
requested review from
a team,
andrew-ronaldson,
kmcfaul,
lboehling,
mcoker and
nicolethoen
and removed request for
a team
Collaborator
|
Preview: https://patternfly-react-pr-9971.surge.sh A11y report: https://patternfly-react-pr-9971-a11y.surge.sh |
wise-king-sullyman
approved these changes
Jan 16, 2024
kmcfaul
approved these changes
Jan 17, 2024
andrew-ronaldson
approved these changes
Jan 18, 2024
Collaborator
andrew-ronaldson
left a comment
andrew-ronaldson
left a comment
There was a problem hiding this comment.
There is a separate issue with Menu toggle but not a blocker for this. Approved
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #9878
Pagination preview
@mcoker based on your page insets comment in the Core PR I removed the prop that added the pf-m-page-inset class. Let me know if this should be reverted.EDIT: adding back per discussion during Penta happy hourAdditional issues: