chore(deps): update novnc to 1.5.0 #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
So turns out this was an intentional change in novnc/noVNC@b35cf6d |
jelly
added a commit
to cockpit-project/cockpit-machines
that referenced
this pull request
Jun 26, 2024
`@patternfly/react-console` depends on `@novnc/novnc` but allows minor and patch version updates. A minor version of novnc broke PatternFly's imports as they removed ES6 imports and therefore imports have to be adjusted. Until `@patternfly/react-console` merges my PR and releases a new version which is still compatible with PF5. novnc/noVNC@b35cf6d patternfly/react-console#57
allisonkarlitskaya
pushed a commit
to cockpit-project/cockpit-machines
that referenced
this pull request
Jun 26, 2024
`@patternfly/react-console` depends on `@novnc/novnc` but allows minor and patch version updates. A minor version of novnc broke PatternFly's imports as they removed ES6 imports and therefore imports have to be adjusted. Until `@patternfly/react-console` merges my PR and releases a new version which is still compatible with PF5. novnc/noVNC@b35cf6d patternfly/react-console#57
jelly
added a commit
to jelly/cockpit-machines
that referenced
this pull request
Jun 26, 2024
`@patternfly/react-console` depends on `@novnc/novnc` but allows minor and patch version updates. A minor version of novnc broke PatternFly's imports as they removed ES6 imports and therefore imports have to be adjusted. Until `@patternfly/react-console` merges my PR and releases a new version which is still compatible with PF5. novnc/noVNC@b35cf6d patternfly/react-console#57
wise-king-sullyman
previously approved these changes
Jun 26, 2024
jelly
added a commit
to cockpit-project/cockpit-machines
that referenced
this pull request
Jun 26, 2024
`@patternfly/react-console` depends on `@novnc/novnc` but allows minor and patch version updates. A minor version of novnc broke PatternFly's imports as they removed ES6 imports and therefore imports have to be adjusted. Until `@patternfly/react-console` merges my PR and releases a new version which is still compatible with PF5. novnc/noVNC@b35cf6d patternfly/react-console#57
Contributor
Author
|
I am a bit clueless about the typescript error, the previous version but it never annotated any types. |
Contributor
Author
|
I've disabled one tsconfig option which made I've followed this blog post on disabling the relevant config option https://mariusschulz.com/blog/untyped-imports-in-typescript |
nicolethoen
approved these changes
Jul 2, 2024
wise-king-sullyman
approved these changes
Jul 2, 2024
|
🎉 This PR is included in version 5.1.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
dlabaj
added a commit
that referenced
this pull request
Jul 30, 2024
* chore(pf-issues): Updated code to push issues to PatternFly Issues. (#52) * Fix link to virt-manager.org/download (#51) * chore: Create dependabot.yml * chore(deps): update novnc to 1.5.0 (#57) * fix(build): Update README.md to restart build that didn't deploy. * fix(beta): Upgraded to beta release candidate and mereged main fixes. fix(beta): * fix(doc-framework): Upgraded to the latest document framework. --------- Co-authored-by: Pierre CORSINI <50719398+pierrecorsini@users.noreply.github.com> Co-authored-by: Nicole Thoen <nthoen@redhat.com> Co-authored-by: Jelle van der Waa <jelle@vdwaa.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a regular update of an unrelated package,
@novnc/novncgot updated to 1.5.0, this seems to be expected as even with^1.5.01.*.*might be updated while with~1.3.0only1.3.Xcan be updated (bug fixes).It would be nice if there could be a new
react-consolerelease which made it more restricted to~1.3.0to unblock or merging this PR. I've tested it oncockpit-machinesand a quick some test seems to work fine.cockpit-project/cockpit-machines#1692