Refactor BroadcastSet to follow consistent entity definition patterns#3
Merged
arminsabouri merged 1 commit intopayjoin:masterfrom Feb 4, 2026
Merged
Conversation
0xZaddyy
changed the title
Collaborator
|
@0xZaddyy can you please squash your two commits together |
arminsabouri
approved these changes
Feb 4, 2026
Collaborator
arminsabouri
left a comment
arminsabouri
left a comment
There was a problem hiding this comment.
Cack
just needs commits to be squashed
format code to fix ci
0xZaddyy
force-pushed
the
cleanup-broadcast-set
branch
from
3452555 to
33b677e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the codebase to follow consistent definition patterns by consolidating entity to use the unified
define_entity!macroSummary
define_entity!macro for consistency with other entitiesBroadcastSetDataenum toBroadcastSetTypeand integrate into entity systemdefine_entity_handle_mut!macro