This repository was archived by the owner on Dec 19, 2025. It is now read-only.
Don't cargo update in MSRV CI job#54
Closed
nothingmuch wants to merge 1 commit intopayjoin:mainfrom
Closed
Conversation
Since not all dependencies have precise semvers constraints, a blanket cargo update can break MSRV. This means that the repository can bitrot, with CI jobs failing in ways not related to changes to the codebase. This is a workaround, see also payjoin#43 for description of the proper way to fix this.
nothingmuch
force-pushed
the
no-cargo-update-in-msrv-job
branch
from
a1dfb2e to
305802a
Compare
6 tasks
Contributor
Author
|
Superseded by #60 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since not all dependencies have precise semvers constraints, a blanket cargo update can break MSRV.
This means that the repository can bitrot, with CI jobs failing in ways not related to changes to the codebase.
This is a workaround, see also #43 for description of the proper way to fix this.