Skip to content
This repository was archived by the owner on Dec 19, 2025. It is now read-only.

update time crate (fixes coverage)#56

Closed
nothingmuch wants to merge 1 commit intopayjoin:mainfrom
nothingmuch:update-time
Closed

update time crate (fixes coverage)#56
nothingmuch wants to merge 1 commit intopayjoin:mainfrom
nothingmuch:update-time

Conversation

@nothingmuch
Copy link
Copy Markdown
Contributor

cargo llvm-cov breaks with the older time crate due to use of hence removed no_coverage feature

@nothingmuch
Copy link
Copy Markdown
Contributor Author

as of #55 & #60, running cargo llvm-cov is still broken as now the pinned version of time is locked at 0.3.20.

this PR needs to be updated to fix #43, where Cargo-recent can allow llvm-cov and Cargo-minimal maintains MSRV

@nothingmuch nothingmuch marked this pull request as draft March 12, 2025 20:09
@benalleng
Copy link
Copy Markdown
Collaborator

benalleng commented Nov 14, 2025

I think we can close this as time is now at version v0.3.41 following our update to the msrv to 1.85.0. Additionally I tested cargo llvm-cov on our latest main commit and can confirm that it works, though our coverage is abysmal

@benalleng benalleng closed this Nov 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants