One thing I noticed is that payjoin-cli v1 is not covered, which is likely due to the missing _danger-local-https in contrib/coverage.sh for the v1 llvm-cov command. This can be addressed in a separate PR.
Originally posted by @spacebear21 in #497 (review)
Follow-up on #475 and #494
There is another issue, which is that payjoin-cli v1 does not handle SIGINT gracefully, so it still gets forcefully shutdown in the e2e tests despite using sigint.
We should add interrupt handlers to payjoin-cli v1 to fix this.
Originally posted by @spacebear21 in #497 (review)
Follow-up on #475 and #494
There is another issue, which is that
payjoin-cliv1 does not handle SIGINT gracefully, so it still gets forcefully shutdown in the e2e tests despite usingsigint.We should add interrupt handlers to
payjoin-cliv1 to fix this.