Skip to content

pjos=0 bool value inverts the BIP78 spec #545

@spacebear21

Description

@spacebear21

BIP78 states:

pjos=0: Signal to the sender that they MUST disallow payment output substitution. (See Unsecured payjoin server)

But our implementation does the inverse, and sets pjos to 1 when disabling output substitution!

            ("pjos", if self.disable_output_substitution { "1" } else { "0" }.to_string()),

This should be fixed to follow the spec (and tested properly).

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueDoes NOT mean "an LLM can do this." Please discuss the constraints and intended approach.

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions