Remove unnecessary URI accessors from public api#1082
Merged
DanGould merged 1 commit intopayjoin:masterfrom Sep 16, 2025
Merged
Remove unnecessary URI accessors from public api#1082DanGould merged 1 commit intopayjoin:masterfrom
DanGould merged 1 commit intopayjoin:masterfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 17775619793Details
💛 - Coveralls |
Contributor
Author
|
@arminsabouri or @spacebear21 i expect one of the integrations previously used or uses the |
Contributor
This was previously used to index the session by for resumption. If we're using receiver_pubkey for this, like we are in payjoin-cli, it may be removed. |
These accessors are only needed internally in the crate. The receiver pubkey is still pub because payjoin-cli (as should other implementations) checks for reuse and uses the pubkey to uniquely identify sessions when resuming.
9400ab4 to
5b0b629
Compare
2 tasks
DanGould
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These accessors are only needed internally in the crate.
The receiver pubkey is still pub because payjoin-cli (as should other implementations) checks for reuse and uses the pubkey to uniquely identify sessions when resuming.
This is following up on @DanGould's observation, but I couldn't find the comment or even remember if it was in a call or on github.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.