Skip to content

Remove unnecessary URI accessors from public api#1082

Merged
DanGould merged 1 commit intopayjoin:masterfrom
nothingmuch:unpub-internal-uri-getters
Sep 16, 2025
Merged

Remove unnecessary URI accessors from public api#1082
DanGould merged 1 commit intopayjoin:masterfrom
nothingmuch:unpub-internal-uri-getters

Conversation

@nothingmuch
Copy link
Copy Markdown
Contributor

These accessors are only needed internally in the crate.

The receiver pubkey is still pub because payjoin-cli (as should other implementations) checks for reuse and uses the pubkey to uniquely identify sessions when resuming.

This is following up on @DanGould's observation, but I couldn't find the comment or even remember if it was in a call or on github.

Pull Request Checklist

Please confirm the following before requesting review:

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Sep 16, 2025

Pull Request Test Coverage Report for Build 17775619793

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.709%

Totals Coverage Status
Change from base Build 17773227581: 0.0%
Covered Lines: 8099
Relevant Lines: 9561

💛 - Coveralls

@nothingmuch
Copy link
Copy Markdown
Contributor Author

@arminsabouri or @spacebear21 i expect one of the integrations previously used or uses the endpoint method or it wouldn't be in the ffi interface, i'm assuming that wouldn't be a pain to live without but lmk if that's wrong please

@nothingmuch nothingmuch marked this pull request as ready for review September 16, 2025 17:03
@DanGould
Copy link
Copy Markdown
Contributor

i expect one of the integrations previously used or uses the endpoint method or it wouldn't be in the ffi interface, i'm assuming that wouldn't be a pain to live without but lmk if that's wrong please

This was previously used to index the session by for resumption. If we're using receiver_pubkey for this, like we are in payjoin-cli, it may be removed.

These accessors are only needed internally in the crate.

The receiver pubkey is still pub because payjoin-cli (as should other
implementations) checks for reuse and uses the pubkey to uniquely
identify sessions when resuming.
Copy link
Copy Markdown
Contributor

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5b0b629

@DanGould DanGould merged commit b6768f6 into payjoin:master Sep 16, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants