Replace psbt_with_fee_contributions with pub fn#1120
Merged
spacebear21 merged 1 commit intopayjoin:masterfrom Sep 30, 2025
Merged
Replace psbt_with_fee_contributions with pub fn#1120spacebear21 merged 1 commit intopayjoin:masterfrom
psbt_with_fee_contributions with pub fn#1120spacebear21 merged 1 commit intopayjoin:masterfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 18135859580Details
💛 - Coveralls |
spacebear21
reviewed
Sep 29, 2025
Comment on lines
+997
to
+998
| /// The Payjoin Psbt with fee contributions applied | ||
| pub fn psbt_with_fee_contributions(&self) -> Psbt { |
Collaborator
There was a problem hiding this comment.
I suggest the following updates to the function name and an accompanying docstring:
Suggested change
| /// The Payjoin Psbt with fee contributions applied | |
| pub fn psbt_with_fee_contributions(&self) -> Psbt { | |
| /// The Payjoin proposal PSBT that the receiver needs to sign | |
| /// | |
| /// In some applications the entity that progresses the typestate | |
| /// is different from the entity that has access to the private keys, | |
| /// so the PSBT to sign must be accessible to such implementers. | |
| pub fn psbt_to_sign(&self) -> Psbt { |
Also, does this need be exposed on the v1 typestate too?
Collaborator
Author
There was a problem hiding this comment.
Also, does this need be exposed on the v1 typestate too?
yes
Collaborator
There was a problem hiding this comment.
Thoughts on the method rename suggestion?
Collaborator
Author
There was a problem hiding this comment.
Oops missed that. I agree with the naming change. Will make that change now
arminsabouri
force-pushed
the
rm-session-history-psbt-with-fees
branch
3 times, most recently
from
df52ab4 to
9acf044
Compare
For the Liana example outlined in payjoin#795 (comment) a pub function is more idiomatic and provides better developer experience as developers will not need to interface with the session history -- just the `ProvisionalProposal` typestate.
arminsabouri
force-pushed
the
rm-session-history-psbt-with-fees
branch
from
9acf044 to
ba6a199
Compare
Collaborator
Author
|
@spacebear21 Last push also exposes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the Liana example outlined in
#795 (comment) a pub function is more idiomatic and provides better developer experience as developers will not need to interface with the session history -- just the
ProvisionalProposaltypestate.Closes: #795
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.