Directory cli fixes#1157
Merged
spacebear21 merged 3 commits intopayjoin:masterfrom Oct 8, 2025
Merged
Conversation
Makes all CLI args `Option<T>`, because unless explicitly provided, args shouldn't override config values.
5 tasks
Collaborator
Pull Request Test Coverage Report for Build 18357327396Details
💛 - Coveralls |
spacebear21
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various fixes for the directory's CLI interface, spun out of #1026
metrics_listen_addrby invoking serve_metrics_tcp from mainmetrics_listen_addroptional in the config struct, and only start the metrics listener if it's notSomePlease confirm the following before requesting review:
AI
in the body of this PR.