Skip to content

Directory cli fixes#1157

Merged
spacebear21 merged 3 commits intopayjoin:masterfrom
nothingmuch:directory-cli-fixes
Oct 8, 2025
Merged

Directory cli fixes#1157
spacebear21 merged 3 commits intopayjoin:masterfrom
nothingmuch:directory-cli-fixes

Conversation

@nothingmuch
Copy link
Copy Markdown
Contributor

Various fixes for the directory's CLI interface, spun out of #1026

  1. actually use metrics_listen_addr by invoking serve_metrics_tcp from main
  2. make metrics_listen_addr optional in the config struct, and only start the metrics listener if it's not Some
  3. make all CLI args optional, use them as overrides only when explicitly provided

Please confirm the following before requesting review:

Makes all CLI args `Option<T>`, because unless explicitly provided, args
shouldn't override config values.
@coveralls
Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 18357327396

Details

  • 0 of 17 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 84.13%

Changes Missing Coverage Covered Lines Changed/Added Lines %
payjoin-directory/src/main.rs 0 4 0.0%
payjoin-directory/src/config.rs 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
payjoin-directory/src/config.rs 2 0.0%
Totals Coverage Status
Change from base Build 18288677845: -0.09%
Covered Lines: 8954
Relevant Lines: 10643

💛 - Coveralls

Copy link
Copy Markdown
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 44e74b0 but I'm also open to just merging #1026 directly as-is since these changes have already been reviewed over there.

@spacebear21 spacebear21 merged commit 407a49c into payjoin:master Oct 8, 2025
10 checks passed
@nothingmuch nothingmuch deleted the directory-cli-fixes branch October 8, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants