Skip to content

Use nixos stable for nix flake#1194

Merged
DanGould merged 2 commits intopayjoin:masterfrom
benalleng:nixos-stable
Nov 24, 2025
Merged

Use nixos stable for nix flake#1194
DanGould merged 2 commits intopayjoin:masterfrom
benalleng:nixos-stable

Conversation

@benalleng
Copy link
Copy Markdown
Collaborator

@benalleng benalleng commented Nov 19, 2025

This moves our nix flake from unstable to the stable channel.

Closes #1187

Pull Request Checklist

Please confirm the following before requesting review:

Realizing that using the unstable channel is not giving us any benefits
in our deps and just generally a safer approach to development here.
@coveralls
Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 19514086147

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.578%

Totals Coverage Status
Change from base Build 18946545260: 0.0%
Covered Lines: 8988
Relevant Lines: 10754

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@nothingmuch nothingmuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, i will test only tomorrow as it's late and i'm working on something else

note that 25.11 should be out soon, so it might be wiser to stick with unstable until then and effectively treat 25.11 as freezing that instead of downgrade and upgrade in case that breaks anyone's setup, but in practice i don't think there will be much of an issue so i'm in favor of merging. such breakage would be much more sensitive to changes in the rust toolchain via rust overlay flake, especially because until a fairly recent flake.lock upgrade i think we were on unstable but because it was stale it was equivalent to 24.11 or so. anyway all this just goes to say if something does break then we have an easy out via 25.11

@arminsabouri
Copy link
Copy Markdown
Collaborator

Is this good to merge?

@DanGould
Copy link
Copy Markdown
Contributor

i'm in favor of merging

-- @nothingmuch

@DanGould DanGould merged commit 92dc5ec into payjoin:master Nov 24, 2025
10 checks passed
@benalleng benalleng deleted the nixos-stable branch March 27, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider using nixos stable channel

5 participants