Remove nightly toolchain flag from recommended precommit#1220
Merged
spacebear21 merged 1 commit intopayjoin:masterfrom Dec 12, 2025
Merged
Remove nightly toolchain flag from recommended precommit#1220spacebear21 merged 1 commit intopayjoin:masterfrom
spacebear21 merged 1 commit intopayjoin:masterfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 20121565157Details
💛 - Coveralls |
Collaborator
|
I am hesitant to have two diverging paths for the pre-commit hook. perhaps now with the ohttp-relay in the monorepo we can just encourage the use of the nix dev env such that the pre-commit must be done within the nix shell? |
Collaborator
|
I don't think we actually need |
011acc9 to
aa787f1
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I asked Claude to give me bash code to select between nix and non-nix environments. So this PR in its entirety was written with AI... UNTIL there was an edit based on spacebear's recommendation below, and the change turned from adding a branching logic to account for the nix shell, to just removing the toolchain flag.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.
Originally, this PR was for adding an if-statement to the recommended pre-commit hook so that it does not attempt to find +nightly for rust formatter. However, as spacebear mentions below, we do not need it anymore as it is enforced. So this change simply removes that flag now.