Skip to content

Specify --tree-root to treefmt flake check#1225

Merged
spacebear21 merged 1 commit intopayjoin:masterfrom
nothingmuch:treefmt-fix
Dec 11, 2025
Merged

Specify --tree-root to treefmt flake check#1225
spacebear21 merged 1 commit intopayjoin:masterfrom
nothingmuch:treefmt-fix

Conversation

@nothingmuch
Copy link
Copy Markdown
Contributor

Since the .git directory is filtered out of the the src files in the sandboxed build, treefmt incorrectly identifies /nix/store as the project root and attempts to format readonly files there

Specifying --tree-root . (will be /build/source in the sandbox container) ensures that only the project files are formatted as expected.

Pull Request Checklist

Please confirm the following before requesting review:

Since the .git directory is filtered out of the the src files in the
sandboxed build, treefmt incorrectly identifies /nix/store as the
project root and attempts to format readonly files there

Specifying `--tree-root .` (will be `/build/source` in the sandbox
container) ensures that only the project files are formatted as
expected.
@nothingmuch
Copy link
Copy Markdown
Contributor Author

Probably superseded by #1221.

coverage report is a false positive (failed to upload)

Copy link
Copy Markdown
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, confirmed it fixes the issue on my machine

@spacebear21 spacebear21 merged commit 35c6220 into payjoin:master Dec 11, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants