You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR is testing whether we can reduce the blocks mined in receiver_consolidates_utxos to reduce the CPU load as it was suggested that perhaps that test was CPU bound leading to a timeout when running nix flake check as referenced in #1228 (comment)
Its also worth considering if this test no longer is effective at testing what it was originally set out to when dramatically reducing the number of blocks. I tend to think it is still an effective test but curious what others think.
This allowed nix flake check to succeed on top of 238d849 where it otherwise failed without this PRs commit
Pull Request Checklist
Please confirm the following before requesting review:
Its also worth considering if this test no longer is effective at testing what it was originally set out to when dramatically reducing the number of blocks. I tend to think it is still an effective test but curious what others think.
I had picked 100 UTXOs to more closely simulate a consolidation tx that e.g. an exchange or other service provider might make (e.g. https://mempool.space/tx/40942260a61b0c51d2ccfe22fbe2ab0c474feab74fac3b7d99e663a1001199c6). Such a large number isn't strictly necessary for test coverage but I think it's nice to sanity check the fee estimation and performance of our API under those conditions.
I think we can avoid this, through caching, splitting the jobs up to reduce the load on individual runs, and transitioning to the dev profile it seems that we can't get it to reliably timeout anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is testing whether we can reduce the blocks mined in receiver_consolidates_utxos to reduce the CPU load as it was suggested that perhaps that test was CPU bound leading to a timeout when running
nix flake checkas referenced in #1228 (comment)Its also worth considering if this test no longer is effective at testing what it was originally set out to when dramatically reducing the number of blocks. I tend to think it is still an effective test but curious what others think.
This allowed
nix flake checkto succeed on top of 238d849 where it otherwise failed without this PRs commitPull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.