Add nix2container workflows for creating payjoin-service docker images#1321
Add nix2container workflows for creating payjoin-service docker images#1321spacebear21 merged 1 commit intopayjoin:masterfrom
Conversation
Pull Request Test Coverage Report for Build 21922060024Details
💛 - Coveralls |
|
Thanks for starting on this! As I'm working on #1323 I realize it would be ideal for developer experience to build testing images on any PR that touches payjoin-service, in addition to the release images created when a tag/release is made. |
|
Ok i will make sure to expand when this job runs to include any payjoin-service change. Right now I have the release activity type set to published but there are a lot of options https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#release though published seems to make the most sense. |
129fc0e to
b76d1f2
Compare
|
Trying to use a secret that was given to me but it isn't working as expected. @spacebear21 could you take a look at an org secret that we might be able to use to write packages? |
ca99e0e to
06af30d
Compare
06af30d to
d8cdd4f
Compare
| inherit tag; | ||
| name = "docker.io/payjoin/${name}"; |
There was a problem hiding this comment.
What does this change achieve?
There was a problem hiding this comment.
The name is what .copyToRegistry tries to push to, without the explicit name the inherited name I think is just a dummy payjoin/payjoin-service-image pathname. Testing this now to confirm
d8cdd4f to
d105c5a
Compare
spacebear21
left a comment
There was a problem hiding this comment.
utACK, merging so we can test the workflow
This is a draft to explore the use of nix2container as our workflow docker deployment mechanism. At the moment I am hand deploying docker images to my personal docker hub when requested but ideally I don't want to do that.
If we can get this working I expect it will be our onestop shop for all things we would want to be a docker image. This should be able to close #1244 unless we feel like we also want to have a separate image for ohttp-relay and payjoin-directory before payjoin-service is completely fleshed out.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.