Skip to content

Add nix2container workflows for creating payjoin-service docker images#1321

Merged
spacebear21 merged 1 commit intopayjoin:masterfrom
benalleng:docker-releases
Feb 11, 2026
Merged

Add nix2container workflows for creating payjoin-service docker images#1321
spacebear21 merged 1 commit intopayjoin:masterfrom
benalleng:docker-releases

Conversation

@benalleng
Copy link
Copy Markdown
Collaborator

This is a draft to explore the use of nix2container as our workflow docker deployment mechanism. At the moment I am hand deploying docker images to my personal docker hub when requested but ideally I don't want to do that.

If we can get this working I expect it will be our onestop shop for all things we would want to be a docker image. This should be able to close #1244 unless we feel like we also want to have a separate image for ohttp-relay and payjoin-directory before payjoin-service is completely fleshed out.

Pull Request Checklist

Please confirm the following before requesting review:

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Feb 9, 2026

Pull Request Test Coverage Report for Build 21922060024

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.263%

Totals Coverage Status
Change from base Build 21918191122: 0.0%
Covered Lines: 10238
Relevant Lines: 12296

💛 - Coveralls

@spacebear21
Copy link
Copy Markdown
Collaborator

Thanks for starting on this! As I'm working on #1323 I realize it would be ideal for developer experience to build testing images on any PR that touches payjoin-service, in addition to the release images created when a tag/release is made.

@benalleng
Copy link
Copy Markdown
Collaborator Author

Ok i will make sure to expand when this job runs to include any payjoin-service change. Right now I have the release activity type set to published but there are a lot of options https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#release though published seems to make the most sense.

@benalleng benalleng force-pushed the docker-releases branch 5 times, most recently from 129fc0e to b76d1f2 Compare February 11, 2026 18:24
@benalleng
Copy link
Copy Markdown
Collaborator Author

Trying to use a secret that was given to me but it isn't working as expected. @spacebear21 could you take a look at an org secret that we might be able to use to write packages?

@benalleng benalleng force-pushed the docker-releases branch 2 times, most recently from ca99e0e to 06af30d Compare February 11, 2026 19:30
@benalleng benalleng marked this pull request as ready for review February 11, 2026 19:31
Comment thread .github/workflows/release-image.yml Outdated
Comment thread .github/workflows/release-image.yml Outdated
Comment thread flake.nix
Comment on lines +178 to +179
inherit tag;
name = "docker.io/payjoin/${name}";
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change achieve?

Copy link
Copy Markdown
Collaborator Author

@benalleng benalleng Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name is what .copyToRegistry tries to push to, without the explicit name the inherited name I think is just a dummy payjoin/payjoin-service-image pathname. Testing this now to confirm

Copy link
Copy Markdown
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, merging so we can test the workflow

@spacebear21 spacebear21 merged commit d0c9daf into payjoin:master Feb 11, 2026
14 checks passed
@benalleng benalleng deleted the docker-releases branch March 27, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants