Fix tests following additive feature changes#450
Merged
DanGould merged 2 commits intopayjoin:masterfrom Jan 2, 2025
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 12577498886Details
💛 - Coveralls |
1. payjoin/_danger-local-https not required in v1 integrations 2. payjoin/contrib/test.sh was not running v1 integration tests since it only specifies send,receive features This was accidentally disabled in fdcc566 Note: this change is not required for payjoin-cli/tests/e2e because there is both a v1 and v2 _danger-local-https in payjoin-cli.
This feature is required to run the v2 test suite and went overlooked in fdcc566
nothingmuch
approved these changes
Jan 2, 2025
| cargo test --locked --package payjoin --verbose --all-features --lib | ||
| cargo test --locked --package payjoin --verbose --features=send,receive --test integration | ||
| cargo test --locked --package payjoin --verbose --no-default-features --features=send,receive,_danger-local-https,v2 --test integration | ||
| cargo test --locked --package payjoin --verbose --no-default-features --features=send,receive,_danger-local-https,v2,io --test integration |
Contributor
There was a problem hiding this comment.
maybe we want to use https://github.com/frewsxcv/cargo-all-features instead of manually enumerating feature combinations? if so then in followup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#430 made some features additive, but didn't properly address the tests to run under the minimal requirements nor the scripts to run the tests.
This fixes that