Add additional tests for uri module#578
Merged
spacebear21 merged 1 commit intopayjoin:masterfrom Mar 24, 2025
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 14042503864Details
💛 - Coveralls |
benalleng
commented
Mar 14, 2025
spacebear21
reviewed
Mar 14, 2025
Comment on lines
+295
to
+300
| let enabled = PayjoinExtras { endpoint: url.clone(), disable_output_substitution: true }; | ||
|
|
||
| let disabled = PayjoinExtras { endpoint: url.clone(), disable_output_substitution: false }; | ||
|
|
||
| assert!(enabled.is_output_substitution_disabled()); | ||
| assert!(!disabled.is_output_substitution_disabled()); |
Collaborator
Collaborator
Author
There was a problem hiding this comment.
Elected to not include a check for is_output_substitution_disabled() as #546 also has complete coverage for that plus the corrected inverse values. Though I did create a serialization test as you referenced in you last review there (though this will likely need to be updated with the inverse 0 <=> 1 in the future still anyways).
fa8b1dd to
9535492
Compare
75851a8 to
9e871f6
Compare
spacebear21
approved these changes
Mar 24, 2025
Collaborator
spacebear21
left a comment
There was a problem hiding this comment.
ACK 9e871f6
I think we should wait until #546 gets merged (which should be imminent), then rebase this PR and combine/correct the output substitution tests per #578 (comment).
This expands the test coverage for the uri module covering all mutants that currently exist. This will likely become the narrowest scope of my mutant ci coverage so that we can start with full coverage and expand the scope out as we catch more mutants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This expands the test coverage for the uri module covering all mutants that currently exist.
This will likely become the narrowest scope of my mutant ci coverage so that we can start with full coverage and expand the scope out as we catch more mutants.
Here is the mutants out for
payjoin/src/uri/*.rsas of c1cc487Details
Note, this is with the
mutants.tomlexclusions from #573 in place