Uniffi dart#829
Conversation
Pull Request Test Coverage Report for Build 16273590740Details
💛 - Coveralls |
spacebear21
force-pushed
the
uniffi-dart
branch
9 times, most recently
from
1f36647 to
a0be22e
Compare
spacebear21
force-pushed
the
uniffi-dart
branch
3 times, most recently
from
eb1c264 to
febe14e
Compare
Specify the language to create bindings for at the creation step Co-authored-by: user <benalleng@gmail.com>
Co-authored-by: spacebear <git@spacebear.dev>
arminsabouri
left a comment
arminsabouri
left a comment
There was a problem hiding this comment.
Amazing work! A nit and a question but everything else looked clean and correct to me.
It would be useful to have build and test instructions in a README similar to what we do for python. That can be left as a follow up item.
utACK 20fd94f
| @@ -0,0 +1,11 @@ | |||
|
|
|||
|
|
|||
| #!/bin/bash | |||
There was a problem hiding this comment.
nit: Move shebang to the first line.
There was a problem hiding this comment.
Also slight prefrence for #!/usr/bin/env bash
| } | ||
| } | ||
|
|
||
| class CheckInputsNotSeenCallback implements payjoin.IsOutputKnown { |
There was a problem hiding this comment.
Something seems a bit funky here (?) Should this class be CheckInOutputKnownCallback
There was a problem hiding this comment.
For inputs seen before I dont think there is much to implement here but for output known could we use the same functionality as IsScriptOwned?
Edit: that actually might be what we already do below.
There was a problem hiding this comment.
Nevermind we do this in the python int. tests as well. Appears like the FFI exported abstract class is misnamed?
class CheckInputsNotSeenCallback(IsOutputKnown):
def __init__(self, connection: RpcClient):
self.connection = connection
def callback(self, _outpoint):
return False
arminsabouri
left a comment
arminsabouri
left a comment
There was a problem hiding this comment.
Meant to approve
utACK 20fd94f
|
Thanks Armin, I will address your feedback in follow-ups since they also touch the Python bindings. Good point about a README. I think the FFI docs need a major re-haul some time soon. |
4 participants
This adds support for producing dart bindings with uniffi via https://github.com/Uniffi-Dart/uniffi-dart.git (pinned commit for now until official releases exist). The unit and integration tests in dart are passing.
Note that the integration test is currently flaky due to issues with
testcontainers, so the dart Github workflow is not introduced in this PR to keep CI reliably passing. #876 adds the workflow separately but should wait until thetestcontainersissue is resolved.