Replaces 'flock' with mkdir locking#886
Merged
nothingmuch merged 1 commit intopayjoin:masterfrom Jul 21, 2025
Merged
Conversation
742ee64 to
269036b
Compare
nothingmuch
suggested changes
Jul 17, 2025
269036b to
0701e44
Compare
Collaborator
Pull Request Test Coverage Report for Build 16359709624Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the Linux-specific
flockcommand with a portable directory-based locking in thetest.shscript. The change ensures compatibility across different Unix-like systems, including macOS, while maintaining the same functionality.Testing
The locking mechanism has been verified with the following test cases:
Closes #878